Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Mar 27, 2025

Using npx degit instead to clone the tutorial as currently when using npx create-next-app npx is retrieving data from npx degit wpengine/faustjs/examples/next/tutorial --force my-app which has out of date cached data.

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Related Issue(s):

wpengine/faustjs.org#316

Testing

Screenshots

Documentation Changes

Dependant PRs

Using npx degit instead to clone the tutorial as currently when using npx create-next-app npx is retrieving data from npx degit wpengine/faustjs/examples/next/tutorial --force my-app which has out of date cached data.
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 0df3523

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colinmurphy colinmurphy marked this pull request as ready for review March 27, 2025 16:53
@colinmurphy colinmurphy requested a review from a team as a code owner March 27, 2025 16:53
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@moonmeister moonmeister enabled auto-merge (squash) March 27, 2025 17:03
@moonmeister moonmeister disabled auto-merge March 27, 2025 17:07
@moonmeister moonmeister merged commit e04baad into canary Mar 27, 2025
1 check passed
@moonmeister moonmeister deleted the bug-fix-issue-faust-tutorial-cache-issue branch March 27, 2025 17:07
colinmurphy added a commit that referenced this pull request Apr 16, 2025
As per issue #2089 there is a cache issue with using npx create app for the example tutorial on Github's side. Not sure why it is only failing for this branch though.
colinmurphy added a commit that referenced this pull request Apr 28, 2025
* Fix the_content link replacements

* simplify the code

* fix formatting

* add fullstops

* fix host_url port

* fix empty space

* fix slash issue

* Updated e2e tests. Delete directories only if they exist for e2e tests.

* Updated e2e tests for example tutorial to use npm degit

As per issue #2089 there is a cache issue with using npx create app for the example tutorial on Github's side. Not sure why it is only failing for this branch though.

* Fixed npm degit issue

* Fixing npm degit.

* Install e2e dependencies

* Fixing npm ci issue for e2e directory

* Updated e2e example test to only run when there is a change within the example directory

* minor improvements

* fix linting

* adding port tests

* Create long-laws-doubt.md

---------

Co-authored-by: Colin Murphy <colinmurphy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants