Skip to content

Fixes #4171 Exclude judge.me script from delay JS #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyperona merged 9 commits into from
Apr 11, 2022
Merged

Fixes #4171 Exclude judge.me script from delay JS #4839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c609ea0
Added a new Thirdparty class for Judge.me that excludes window.jdgmSe…
CrochetFeve0251 Mar 22, 2022
baad84a
Added Integration test for JudgeMe third party class
CrochetFeve0251 Mar 22, 2022
c459a74
Fixed comment to respect code standards
CrochetFeve0251 Mar 22, 2022
f85a12d
Refactored the solution for Judge.me
CrochetFeve0251 Mar 29, 2022
7a09684
Removed Judge.me subscriber traces
CrochetFeve0251 Mar 29, 2022
b3638c3
Fixed code standards
CrochetFeve0251 Mar 29, 2022
9af7b32
Removed files for old solution
CrochetFeve0251 Mar 29, 2022
ed2b9ad
Removed group from exclusions
CrochetFeve0251 Mar 29, 2022
a64ff28
Merge branch 'develop' into fix/4171-create-judge-class
remyperona Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions inc/Engine/Optimization/DelayJS/HTML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ class HTML {
'var sc_project', // Statscounter.
'/jetpack/jetpack_vendor/automattic/jetpack-lazy-images/(.*)', // Jetpack plugin lazyload.
'/themify-builder/themify/js/modules/fallback(\.min)?.js',
'window.jdgmSettings', // Judge.me plugin.
];

/**
Expand Down
3 changes: 3 additions & 0 deletions tests/Fixtures/inc/Engine/Optimization/DelayJS/HTML/delayJs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<script src="http://example.org/wp-content/plugins/sitepress-multilingual-cms/dist/js/browser-redirect/app.js"></script>
<script type="text/javascript" async="async" data-noptimize="1" data-cfasync="false" src="//scripts.mediavine.com/tags/test.js"></script>
<script type="application/ld+json" class="yoast-schema-graph">{"@context":"https://schema.org","@graph":[{"@type":"WebSite","@id":"http://example.org/#website","url":"http://example.org/"]}</script>
<script class=\'jdgm-settings-script\'>window.jdgmSettings={"pagination":5,"badge_no_review_text":"0 reviews","badge_n_reviews_text":"{{ n }} Review/Reviews","badge_star_color":"#ffde00","hide_badge_preview_if_no_reviews":true,"widget_title":"Echte klantreviews","widget_open_form_text":"Scrhijf jouw review","widget_close_form_text":"Cancel","widget_refresh_page_text":"Ververs pagina","widget_summary_text":"Gebaseerd op {{ number_of_reviews }} review/reviews","widget_no_review_text":"Nog geen reviews","widget_name_field_text":"Naam","widget_verified_name_field_text":"Geverifieerde naam (public)","widget_name_placeholder_text":"Voer je naam in (public)","widget_required_field_error_text":"Dit veld is verplicht","widget_email_field_text":"E-mail","widget_verified_email_field_text":"Geverifieerd e-mailadres (privé, kan niet worden bewerkt)","widget_email_placeholder_text":"Voer je e-mailadres in (privé)","widget_email_field_error_text":"Gelieve een geldig e-mailadres in te geven.","widget_rating_field_text":"Review","widget_review_title_field_text":"Review Titel","widget_review_title_placeholder_text":"Geef je review een titel","widget_review_body_field_text":"Review","widget_review_body_placeholder_text":"Geef jouw mening","widget_pictures_field_text":"Foto\'s of video (optie)","widget_submit_review_text":"Verstuur review","widget_submit_verified_review_text":"Verstuur review","widget_submit_success_msg_with_auto_publish":"Bedankt voor je review! Als je je pagina ververst kun je jouw vers geschreven review teruglezen. Je kunt \'m zelfs delen via social media.","widget_submit_success_msg_no_auto_publish":"Bedankt voor je review! Je review word eerst beoordeeld. Je kunt \'m later ook delen via social media.","widget_show_default_reviews_out_of_total_text":"{{ n_reviews_shown }} wordt weergegeven bij {{ n_reviews }} beoordelingen.","widget_show_all_link_text":"Toon alles","widget_show_less_link_text":"Laat minder zien","widget_author_said_text":"{{ reviewer_name }} zei:","widget_days_text":"{{ n }} dagen geleden","widget_weeks_text":"{{ n }} week/weken geleden","widget_months_text":"{{ n }} maanden/maanden geleden","widget_years_text":"{{ n }} jaar/jaar geleden","widget_yesterday_text":"Gisteren","widget_today_text":"Vandaag","widget_replied_text":"Reactie van {{ shop_name }}:","widget_read_more_text":"Lees meer","widget_reviewer_name_as_initial":"last_initial","widget_rating_filter_see_all_text":"Alle beoordelingen bekijken","widget_sorting_most_recent_text":"Meest recent","widget_sorting_highest_rating_text":"Hoogste beoordeling","widget_sorting_lowest_rating_text":"Laagste beoordeling","widget_sorting_with_pictures_text":"Alleen foto\'s","widget_sorting_most_helpful_text":"Meest behulpzaam","widget_open_question_form_text":"Stel een vraag","widget_reviews_subtab_text":"Review","widget_questions_subtab_text":"Vragen","widget_question_label_text":"Vragen","widget_answer_label_text":"Antwoorden","widget_question_placeholder_text":"Schrijf je vraag","widget_submit_question_text":"Verstuur je vraag","widget_question_submit_success_text":"Bedankt voor je vraag! We zullen u op de hoogte stellen en uw vraag zal worden gepubliceerd zodra deze is beantwoord.","widget_star_color":"#ffd600","verified_badge_text":"Geverifieerd ","verified_badge_placement":"left-of-reviewer-name","widget_review_max_height":4,"widget_social_share":true,"widget_thumb":true,"widget_review_location_show":true,"widget_location_format":"country_iso_code","all_reviews_include_out_of_store_products":true,"all_reviews_out_of_store_text":"(uit winkel)","all_reviews_product_name_prefix_text":"over","enable_review_pictures":true,"enable_question_anwser":true,"review_date_format":"dd/mm/yyyy","default_sort_method":"most-helpful","widget_product_reviews_subtab_text":"Product recensies","widget_shop_reviews_subtab_text":"Winkel beoordelingen","show_product_url_for_grouped_product":true,"widget_sorting_pictures_first_text":"Foto\'s eerst","show_pictures_on_all_rev_page_mobile":true,"show_pictures_on_all_rev_page_desktop":true,"floating_tab_button_name":"★ Judge.me beoordelingen","floating_tab_title":"Laat klanten voor ons spreken","all_reviews_text_badge_text":"Klanten beoordelen ons {{ shop.metafields.judgeme.all_reviews_rating | round: 1 }}/5 gebaseerd op {{ shop.metafields.judgeme.all_reviews_count }} - recensies.","featured_carousel_title":"Laat klanten voor ons spreken","featured_carousel_count_text":"van {{ n }} recensies","featured_carousel_autoslide_interval":0,"featured_carousel_image_size":300,"featured_carousel_arrow_color":"#575757","picture_reminder_submit_button":"Upload afbeeldingen","enable_review_videos":true,"mute_video_by_default":true,"widget_sorting_videos_first_text":"Video\'s eerst","widget_review_pending_text":"In afwachting","social_share_options_order":"Facebook,Twitter,Pinterest,LinkedIn","preview_badge_show_question_text":true,"preview_badge_no_question_text":"0 Productvragen","preview_badge_n_question_text":"{{ number_of_questions }} vraag/vragen","qa_badge_show_icon":true,"widget_add_search_bar":true,"widget_search_bar_placeholder":"Doorzoek reviews","widget_sorting_verified_only_text":"Alleen geverifieerd","featured_carousel_theme":"aligned","featured_carousel_full_star_background":"#ffd600","all_reviews_page_load_more_text":"Laad meer recensies","widget_public_name_text":"openbaar weergegeven als","widget_reviewer_anonymous":"Anoniem","medals_widget_title":"Judge.me Review-medailles","platform":"woocommerce","branding_url":"https://judge.me/reviews","branding_text":"Via Judge.me","locale":"nl","reply_name":"Grill Bill Kamado BBQ","footer":true,"autopublish":true,"review_dates":true,"enable_custom_form":true};</script>
<script>var et_site_url=\'http://example.org\';var et_post_id=\'2\';function et_core_page_resource_fallback(a,b){"undefined"===typeof b&&(b=a.sheet.cssRules&&0===a.sheet.cssRules.length);b&&(a.onerror=null,a.onload=null,a.href?a.href=et_site_url+"/?et_core_page_resource="+a.id+et_post_id:a.src&&(a.src=et_site_url+"/?et_core_page_resource="+a.id+et_post_id))}
</script>
<script>var lepopup_customjs_handlers={};var lepopup_cookie_value="1624338829";var lepopup_events_data={};var lepopup_content_id="23638";</script>
Expand Down Expand Up @@ -199,6 +200,7 @@
<script src="http://example.org/wp-content/plugins/sitepress-multilingual-cms/dist/js/browser-redirect/app.js"></script>
<script type="text/javascript" async="async" data-noptimize="1" data-cfasync="false" src="//scripts.mediavine.com/tags/test.js"></script>
<script type="application/ld+json" class="yoast-schema-graph">{"@context":"https://schema.org","@graph":[{"@type":"WebSite","@id":"http://example.org/#website","url":"http://example.org/"]}</script>
<script class=\'jdgm-settings-script\'>window.jdgmSettings={"pagination":5,"badge_no_review_text":"0 reviews","badge_n_reviews_text":"{{ n }} Review/Reviews","badge_star_color":"#ffde00","hide_badge_preview_if_no_reviews":true,"widget_title":"Echte klantreviews","widget_open_form_text":"Scrhijf jouw review","widget_close_form_text":"Cancel","widget_refresh_page_text":"Ververs pagina","widget_summary_text":"Gebaseerd op {{ number_of_reviews }} review/reviews","widget_no_review_text":"Nog geen reviews","widget_name_field_text":"Naam","widget_verified_name_field_text":"Geverifieerde naam (public)","widget_name_placeholder_text":"Voer je naam in (public)","widget_required_field_error_text":"Dit veld is verplicht","widget_email_field_text":"E-mail","widget_verified_email_field_text":"Geverifieerd e-mailadres (privé, kan niet worden bewerkt)","widget_email_placeholder_text":"Voer je e-mailadres in (privé)","widget_email_field_error_text":"Gelieve een geldig e-mailadres in te geven.","widget_rating_field_text":"Review","widget_review_title_field_text":"Review Titel","widget_review_title_placeholder_text":"Geef je review een titel","widget_review_body_field_text":"Review","widget_review_body_placeholder_text":"Geef jouw mening","widget_pictures_field_text":"Foto\'s of video (optie)","widget_submit_review_text":"Verstuur review","widget_submit_verified_review_text":"Verstuur review","widget_submit_success_msg_with_auto_publish":"Bedankt voor je review! Als je je pagina ververst kun je jouw vers geschreven review teruglezen. Je kunt \'m zelfs delen via social media.","widget_submit_success_msg_no_auto_publish":"Bedankt voor je review! Je review word eerst beoordeeld. Je kunt \'m later ook delen via social media.","widget_show_default_reviews_out_of_total_text":"{{ n_reviews_shown }} wordt weergegeven bij {{ n_reviews }} beoordelingen.","widget_show_all_link_text":"Toon alles","widget_show_less_link_text":"Laat minder zien","widget_author_said_text":"{{ reviewer_name }} zei:","widget_days_text":"{{ n }} dagen geleden","widget_weeks_text":"{{ n }} week/weken geleden","widget_months_text":"{{ n }} maanden/maanden geleden","widget_years_text":"{{ n }} jaar/jaar geleden","widget_yesterday_text":"Gisteren","widget_today_text":"Vandaag","widget_replied_text":"Reactie van {{ shop_name }}:","widget_read_more_text":"Lees meer","widget_reviewer_name_as_initial":"last_initial","widget_rating_filter_see_all_text":"Alle beoordelingen bekijken","widget_sorting_most_recent_text":"Meest recent","widget_sorting_highest_rating_text":"Hoogste beoordeling","widget_sorting_lowest_rating_text":"Laagste beoordeling","widget_sorting_with_pictures_text":"Alleen foto\'s","widget_sorting_most_helpful_text":"Meest behulpzaam","widget_open_question_form_text":"Stel een vraag","widget_reviews_subtab_text":"Review","widget_questions_subtab_text":"Vragen","widget_question_label_text":"Vragen","widget_answer_label_text":"Antwoorden","widget_question_placeholder_text":"Schrijf je vraag","widget_submit_question_text":"Verstuur je vraag","widget_question_submit_success_text":"Bedankt voor je vraag! We zullen u op de hoogte stellen en uw vraag zal worden gepubliceerd zodra deze is beantwoord.","widget_star_color":"#ffd600","verified_badge_text":"Geverifieerd ","verified_badge_placement":"left-of-reviewer-name","widget_review_max_height":4,"widget_social_share":true,"widget_thumb":true,"widget_review_location_show":true,"widget_location_format":"country_iso_code","all_reviews_include_out_of_store_products":true,"all_reviews_out_of_store_text":"(uit winkel)","all_reviews_product_name_prefix_text":"over","enable_review_pictures":true,"enable_question_anwser":true,"review_date_format":"dd/mm/yyyy","default_sort_method":"most-helpful","widget_product_reviews_subtab_text":"Product recensies","widget_shop_reviews_subtab_text":"Winkel beoordelingen","show_product_url_for_grouped_product":true,"widget_sorting_pictures_first_text":"Foto\'s eerst","show_pictures_on_all_rev_page_mobile":true,"show_pictures_on_all_rev_page_desktop":true,"floating_tab_button_name":"★ Judge.me beoordelingen","floating_tab_title":"Laat klanten voor ons spreken","all_reviews_text_badge_text":"Klanten beoordelen ons {{ shop.metafields.judgeme.all_reviews_rating | round: 1 }}/5 gebaseerd op {{ shop.metafields.judgeme.all_reviews_count }} - recensies.","featured_carousel_title":"Laat klanten voor ons spreken","featured_carousel_count_text":"van {{ n }} recensies","featured_carousel_autoslide_interval":0,"featured_carousel_image_size":300,"featured_carousel_arrow_color":"#575757","picture_reminder_submit_button":"Upload afbeeldingen","enable_review_videos":true,"mute_video_by_default":true,"widget_sorting_videos_first_text":"Video\'s eerst","widget_review_pending_text":"In afwachting","social_share_options_order":"Facebook,Twitter,Pinterest,LinkedIn","preview_badge_show_question_text":true,"preview_badge_no_question_text":"0 Productvragen","preview_badge_n_question_text":"{{ number_of_questions }} vraag/vragen","qa_badge_show_icon":true,"widget_add_search_bar":true,"widget_search_bar_placeholder":"Doorzoek reviews","widget_sorting_verified_only_text":"Alleen geverifieerd","featured_carousel_theme":"aligned","featured_carousel_full_star_background":"#ffd600","all_reviews_page_load_more_text":"Laad meer recensies","widget_public_name_text":"openbaar weergegeven als","widget_reviewer_anonymous":"Anoniem","medals_widget_title":"Judge.me Review-medailles","platform":"woocommerce","branding_url":"https://judge.me/reviews","branding_text":"Via Judge.me","locale":"nl","reply_name":"Grill Bill Kamado BBQ","footer":true,"autopublish":true,"review_dates":true,"enable_custom_form":true};</script>
<script>var et_site_url=\'http://example.org\';var et_post_id=\'2\';function et_core_page_resource_fallback(a,b){"undefined"===typeof b&&(b=a.sheet.cssRules&&0===a.sheet.cssRules.length);b&&(a.onerror=null,a.onload=null,a.href?a.href=et_site_url+"/?et_core_page_resource="+a.id+et_post_id:a.src&&(a.src=et_site_url+"/?et_core_page_resource="+a.id+et_post_id))}
</script>
<script>var lepopup_customjs_handlers={};var lepopup_cookie_value="1624338829";var lepopup_events_data={};var lepopup_content_id="23638";</script>
Expand Down Expand Up @@ -375,6 +377,7 @@
<script src="http://example.org/wp-content/plugins/sitepress-multilingual-cms/dist/js/browser-redirect/app.js"></script>
<script type="text/javascript" async="async" data-noptimize="1" data-cfasync="false" src="//scripts.mediavine.com/tags/test.js"></script>
<script type="application/ld+json" class="yoast-schema-graph">{"@context":"https://schema.org","@graph":[{"@type":"WebSite","@id":"http://example.org/#website","url":"http://example.org/"]}</script>
<script class=\'jdgm-settings-script\'>window.jdgmSettings={"pagination":5,"badge_no_review_text":"0 reviews","badge_n_reviews_text":"{{ n }} Review/Reviews","badge_star_color":"#ffde00","hide_badge_preview_if_no_reviews":true,"widget_title":"Echte klantreviews","widget_open_form_text":"Scrhijf jouw review","widget_close_form_text":"Cancel","widget_refresh_page_text":"Ververs pagina","widget_summary_text":"Gebaseerd op {{ number_of_reviews }} review/reviews","widget_no_review_text":"Nog geen reviews","widget_name_field_text":"Naam","widget_verified_name_field_text":"Geverifieerde naam (public)","widget_name_placeholder_text":"Voer je naam in (public)","widget_required_field_error_text":"Dit veld is verplicht","widget_email_field_text":"E-mail","widget_verified_email_field_text":"Geverifieerd e-mailadres (privé, kan niet worden bewerkt)","widget_email_placeholder_text":"Voer je e-mailadres in (privé)","widget_email_field_error_text":"Gelieve een geldig e-mailadres in te geven.","widget_rating_field_text":"Review","widget_review_title_field_text":"Review Titel","widget_review_title_placeholder_text":"Geef je review een titel","widget_review_body_field_text":"Review","widget_review_body_placeholder_text":"Geef jouw mening","widget_pictures_field_text":"Foto\'s of video (optie)","widget_submit_review_text":"Verstuur review","widget_submit_verified_review_text":"Verstuur review","widget_submit_success_msg_with_auto_publish":"Bedankt voor je review! Als je je pagina ververst kun je jouw vers geschreven review teruglezen. Je kunt \'m zelfs delen via social media.","widget_submit_success_msg_no_auto_publish":"Bedankt voor je review! Je review word eerst beoordeeld. Je kunt \'m later ook delen via social media.","widget_show_default_reviews_out_of_total_text":"{{ n_reviews_shown }} wordt weergegeven bij {{ n_reviews }} beoordelingen.","widget_show_all_link_text":"Toon alles","widget_show_less_link_text":"Laat minder zien","widget_author_said_text":"{{ reviewer_name }} zei:","widget_days_text":"{{ n }} dagen geleden","widget_weeks_text":"{{ n }} week/weken geleden","widget_months_text":"{{ n }} maanden/maanden geleden","widget_years_text":"{{ n }} jaar/jaar geleden","widget_yesterday_text":"Gisteren","widget_today_text":"Vandaag","widget_replied_text":"Reactie van {{ shop_name }}:","widget_read_more_text":"Lees meer","widget_reviewer_name_as_initial":"last_initial","widget_rating_filter_see_all_text":"Alle beoordelingen bekijken","widget_sorting_most_recent_text":"Meest recent","widget_sorting_highest_rating_text":"Hoogste beoordeling","widget_sorting_lowest_rating_text":"Laagste beoordeling","widget_sorting_with_pictures_text":"Alleen foto\'s","widget_sorting_most_helpful_text":"Meest behulpzaam","widget_open_question_form_text":"Stel een vraag","widget_reviews_subtab_text":"Review","widget_questions_subtab_text":"Vragen","widget_question_label_text":"Vragen","widget_answer_label_text":"Antwoorden","widget_question_placeholder_text":"Schrijf je vraag","widget_submit_question_text":"Verstuur je vraag","widget_question_submit_success_text":"Bedankt voor je vraag! We zullen u op de hoogte stellen en uw vraag zal worden gepubliceerd zodra deze is beantwoord.","widget_star_color":"#ffd600","verified_badge_text":"Geverifieerd ","verified_badge_placement":"left-of-reviewer-name","widget_review_max_height":4,"widget_social_share":true,"widget_thumb":true,"widget_review_location_show":true,"widget_location_format":"country_iso_code","all_reviews_include_out_of_store_products":true,"all_reviews_out_of_store_text":"(uit winkel)","all_reviews_product_name_prefix_text":"over","enable_review_pictures":true,"enable_question_anwser":true,"review_date_format":"dd/mm/yyyy","default_sort_method":"most-helpful","widget_product_reviews_subtab_text":"Product recensies","widget_shop_reviews_subtab_text":"Winkel beoordelingen","show_product_url_for_grouped_product":true,"widget_sorting_pictures_first_text":"Foto\'s eerst","show_pictures_on_all_rev_page_mobile":true,"show_pictures_on_all_rev_page_desktop":true,"floating_tab_button_name":"★ Judge.me beoordelingen","floating_tab_title":"Laat klanten voor ons spreken","all_reviews_text_badge_text":"Klanten beoordelen ons {{ shop.metafields.judgeme.all_reviews_rating | round: 1 }}/5 gebaseerd op {{ shop.metafields.judgeme.all_reviews_count }} - recensies.","featured_carousel_title":"Laat klanten voor ons spreken","featured_carousel_count_text":"van {{ n }} recensies","featured_carousel_autoslide_interval":0,"featured_carousel_image_size":300,"featured_carousel_arrow_color":"#575757","picture_reminder_submit_button":"Upload afbeeldingen","enable_review_videos":true,"mute_video_by_default":true,"widget_sorting_videos_first_text":"Video\'s eerst","widget_review_pending_text":"In afwachting","social_share_options_order":"Facebook,Twitter,Pinterest,LinkedIn","preview_badge_show_question_text":true,"preview_badge_no_question_text":"0 Productvragen","preview_badge_n_question_text":"{{ number_of_questions }} vraag/vragen","qa_badge_show_icon":true,"widget_add_search_bar":true,"widget_search_bar_placeholder":"Doorzoek reviews","widget_sorting_verified_only_text":"Alleen geverifieerd","featured_carousel_theme":"aligned","featured_carousel_full_star_background":"#ffd600","all_reviews_page_load_more_text":"Laad meer recensies","widget_public_name_text":"openbaar weergegeven als","widget_reviewer_anonymous":"Anoniem","medals_widget_title":"Judge.me Review-medailles","platform":"woocommerce","branding_url":"https://judge.me/reviews","branding_text":"Via Judge.me","locale":"nl","reply_name":"Grill Bill Kamado BBQ","footer":true,"autopublish":true,"review_dates":true,"enable_custom_form":true};</script>
<script>var et_site_url=\'http://example.org\';var et_post_id=\'2\';function et_core_page_resource_fallback(a,b){"undefined"===typeof b&&(b=a.sheet.cssRules&&0===a.sheet.cssRules.length);b&&(a.onerror=null,a.onload=null,a.href?a.href=et_site_url+"/?et_core_page_resource="+a.id+et_post_id:a.src&&(a.src=et_site_url+"/?et_core_page_resource="+a.id+et_post_id))}
</script>
<script>var lepopup_customjs_handlers={};var lepopup_cookie_value="1624338829";var lepopup_events_data={};var lepopup_content_id="23638";</script>
Expand Down