fix S3 multipart uploads failing on large files#110
Open
webaware wants to merge 3 commits intowp-media:masterfrom
Open
fix S3 multipart uploads failing on large files#110webaware wants to merge 3 commits intowp-media:masterfrom
webaware wants to merge 3 commits intowp-media:masterfrom
Conversation
could be something other than an AwsException
Contributor
|
@webaware Thank you for the PR. I really appreciate it ❤️ |
Author
|
G'day Cuong, yes the forced garbage collection does resolve the problem -- memory stays at a stable level during the upload. Memory usage is a little more than using AWS' MultipartUploader, and also is doing more work by extracting temporary files to upload, so AWS' MultipartUploader is still the preferable method. |
Contributor
|
Good day @webaware thank you for your help, I forwarded the PR to our dev :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazon S3 backups fail in BackWPup v3.6.10 - v3.8.0 when the backup file is very large (e.g. gigabytes). Previously logged on wp.org support forum.
A sample error looks like this:
This PR fixes the problem by replacing the multipart code with the recommended AWS SDK code using the
MultipartUploaderclass to manage the upload.