Updates deprecated DataSource::resolve_post_object #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
approved these changes
Feb 1, 2023
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -232,7 +231,9 @@ public static function register() { | |||
| 'type' => 'MediaItem', | |||
| 'description' => __( 'Product variation main image', 'wp-graphql-woocommerce' ), | |||
| 'resolve' => function( $source, array $args, AppContext $context ) { | |||
| return ! empty( $source->image_id ) ? DataSource::resolve_post_object( $source->image_id, $context ) : null; | |||
| return ! empty( $source->image_id ) | |||
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit 047f0dd and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 70.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
Fixes deprecation errors:
Updates usage of deprecated function.
Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
…
Where has this been tested?