Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coupon type #6

Merged
merged 11 commits into from
Mar 17, 2019
Merged

Feature/coupon type #6

merged 11 commits into from
Mar 17, 2019

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Mar 16, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Codeception tests for Coupon type
  • Coupon type & connections
  • WooCommerce post-types & taxonomies registered to GraphQL schema

Example Query

// the "coupon" query accepts a relay global id

coupon( id: "some relay id" ) {
    couponId
    code
    amount
    date
    modified
    discountType
    description
    dateExpiry
    usageCount
    individualUse
    usageLimit
    usageLimitPerUser
    limitUsageToXItems
    freeShipping
    excludeSaleItems
    minimumAmount
    maximumAmount
    emailRestrictions
}

// the "couponBy" query accepts "couponId" and "code"

couponBy( couponId: "some coupon id" ) {
    ...
}

// the "coupons" query accepts the standard connection params like "first" and "where"
// "code" is the only where param right now but more will be added

coupons( first: 5, where: { code: "some coupon code" } ) {
    nodes {
        ...
    }
}

There are five more five connections to the Coupon that have been created yet due to the types or fields required having not been created yet. There are

  • products - Product
  • excludedProducts - Product
  • productCategories - Category
  • excludedProductCategories - Category
  • usedBy - User
    These also cause the CouponQueriesTest to fail as well.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.1

@kidunot89 kidunot89 self-assigned this Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant