Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.7.0 #383

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Release v0.7.0 #383

merged 1 commit into from
Nov 24, 2020

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Nov 24, 2020

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • CartItem fields product and variation changed to one-to-one connections.
  • attributes added as an edge field on the variation connection.
  • Test added for new fields.

Example

query ($key: ID!) {
	cartItem(key: $key) {
		key
		product {
			node {
				id
				databaseId
			}
		}
		variation {
			attributes {
				id
				attributeId
				name
				label
				value
			}
			node {
				id
				databaseId
			}
		}
		quantity
		subtotal
		subtotalTax
		total
		tax
	}
}

Does this close any currently open issues?

Closes #284 #283 #280

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04

WordPress Version: 5.5.3

@kidunot89 kidunot89 self-assigned this Nov 24, 2020
@kidunot89 kidunot89 merged commit fb6578d into develop Nov 24, 2020
@kidunot89 kidunot89 deleted the release/v0.7.0 branch July 5, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CartItem Variation Field in Cart Query
1 participant