Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field caps removed from product raw price and description fields. #332

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Aug 11, 2020

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Remove permission checks from the raw-formatted product fields
    • price
    • regularPrice
    • salePrice
    • description
    • shortDescription

Does this close any currently open issues?

Fixes #330

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04

WordPress Version: 5.4.2

@kidunot89 kidunot89 added the enhancement New feature or request label Aug 11, 2020
@kidunot89 kidunot89 self-assigned this Aug 11, 2020
@kidunot89 kidunot89 added the work in progress Solution development in progress label Aug 11, 2020
@kidunot89 kidunot89 merged commit f2a6a3d into wp-graphql:release/v0.6.0 Sep 7, 2020
@kidunot89 kidunot89 deleted the bugfix/price-format-permission-removed branch September 7, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress Solution development in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQl Error when querying price fields ("regularPrice", "price" and "salePrice") whether formatted or not
1 participant