Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two new fields added to the "ProductCategory" type. #318

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jul 7, 2020

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Adds the display and order fields to the ProductCategory type.
  • Adds the ProductCategoryDisplay enumeration.
  • New ProductCategory test added

NOTE: by default product category are always assigned an order

Does this close any currently open issues?

Fixes #277

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04

WordPress Version: 5.4.2

@kidunot89 kidunot89 added enhancement New feature or request new fields Feature adds new fields to existing types labels Jul 7, 2020
@kidunot89 kidunot89 self-assigned this Jul 7, 2020
@kidunot89 kidunot89 added the work in progress Solution development in progress label Jul 7, 2020
@PlusA2M
Copy link

PlusA2M commented Jul 13, 2020

I think the field order should be menuOrder to keep consistent the naming convention along with the menuOrder of menuItems and other objects. @kidunot89

@kidunot89 kidunot89 changed the base branch from develop to release/v0.6.0 July 29, 2020 16:50
@kidunot89 kidunot89 force-pushed the feature/product-category-meta branch from 92ef2c8 to edf10a8 Compare August 6, 2020 20:03
@kidunot89 kidunot89 merged commit 3b7bd5d into wp-graphql:release/v0.6.0 Aug 6, 2020
@kidunot89 kidunot89 deleted the feature/product-category-meta branch August 6, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new fields Feature adds new fields to existing types work in progress Solution development in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Categories - "Display" and "Menu Order" attributes
2 participants