Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cart item validation and error handling on checkout #315

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jul 6, 2020

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Processes cart item validation errors during the checkout mutation.
  • Removes deprecated fields and argument forgotten in v0.5.x release.
  • Adds support for changes made to WC_Cart::add_to_cart().

Does this close any currently open issues?

Fixes #313
Fixes #308

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04

WordPress Version: 5.4.2

@kidunot89 kidunot89 added work in progress Solution development in progress bugfix Implements bugfix labels Jul 6, 2020
@kidunot89 kidunot89 self-assigned this Jul 6, 2020
@kidunot89 kidunot89 changed the base branch from develop to release/v0.6.0 July 29, 2020 16:53
@kidunot89 kidunot89 force-pushed the bugfix/cart-item-checkout-validation branch from e2e6386 to c8ce2db Compare October 2, 2020 16:38
@kidunot89 kidunot89 merged commit 531fac9 into wp-graphql:release/v0.6.0 Oct 3, 2020
@kidunot89 kidunot89 deleted the bugfix/cart-item-checkout-validation branch October 3, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix work in progress Solution development in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stock quantity not decreased when creating an order. Checkout mutation allows 'Out of Stock' product
1 participant