Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : #303 #304

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Fixed : #303 #304

merged 1 commit into from
Jun 22, 2020

Conversation

hwsiew
Copy link
Contributor

@hwsiew hwsiew commented Jun 22, 2020

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

WPGraphQL\WooCommerce\Mode\Order doesn't have parent field, instead parent_id should be used to access order's parent id in Order type.

'parent_id' => function() {
return ! empty( $this->data ) ? $this->data->get_parent_id() : null;
},

Does this close any currently open issues?

#303

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
no

Any other comments?

no

Where has this been tested?

Server: nginx php7.4.1

WordPress Version: 5.4.2

@kidunot89 kidunot89 self-requested a review June 22, 2020 23:08
@kidunot89 kidunot89 merged commit 7a3fa63 into wp-graphql:develop Jun 22, 2020
@kidunot89
Copy link
Member

@hwsiew Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants