Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip conditional added to stripe test #298

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Adds a conditional to the Stripe checkout tests that will skip the tests if no Stripe API test keys have been provided.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04

WordPress Version: 5.4.1

@kidunot89 kidunot89 added the dev-ops PR resolves an issue or implements a feature related to the development process label Jun 9, 2020
@kidunot89 kidunot89 self-assigned this Jun 9, 2020
@kidunot89 kidunot89 merged commit 14f5316 into wp-graphql:develop Jun 15, 2020
@kidunot89 kidunot89 deleted the devops/stripe-test-skipped-pr branch June 15, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-ops PR resolves an issue or implements a feature related to the development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant