Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates some product fields' access levels #213

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Updates some product fields' access levels #213

merged 1 commit into from
Jan 11, 2020

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

This adds a layer of security on some Product fields to prevent the leakage of sensitive data.

Protected product fields

  • totalSales
  • catalogVisibility

Does this close any currently open issues?

#210

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

…

Where has this been tested?

Operating System: Linux Mint 19.2

WordPress Version: 5.3.2

@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels Jan 11, 2020
@kidunot89 kidunot89 added this to the v0.3.3 milestone Jan 11, 2020
@kidunot89 kidunot89 self-assigned this Jan 11, 2020
@kidunot89 kidunot89 changed the title new field cap check set. Updates some product fields' security Jan 11, 2020
@kidunot89 kidunot89 changed the title Updates some product fields' security Updates some product fields' access levels Jan 11, 2020
@kidunot89 kidunot89 merged commit 411a27e into wp-graphql:develop Jan 11, 2020
@kidunot89 kidunot89 deleted the feature/product-field-permissions branch January 11, 2020 20:57
@kidunot89 kidunot89 mentioned this pull request Jan 12, 2020
Merged
@creative-andrew creative-andrew mentioned this pull request Nov 23, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kidunot89 kidunot89

Labels
bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.
1 participant
@kidunot89