Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query products by slug and sku #101

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jul 10, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Adds slug and sku arguments to productBy query, with updated tests.

  • ProductQueriesTest updated.

Example Usage

query ( $slug: String, $sku: String ) {
	productBy( slug: $slug, sku: $sku ) {
		...product fields
	}
}

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels Jul 10, 2019
@kidunot89 kidunot89 self-assigned this Jul 10, 2019
@kidunot89 kidunot89 merged commit eccbcba into wp-graphql:release-v0.2.0 Jul 10, 2019
@kidunot89 kidunot89 deleted the bugfix/query-product-by-slug branch July 10, 2019 02:20
@kidunot89 kidunot89 mentioned this pull request Jul 10, 2019
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant