Cognitive complexity of "mutate_and_get_payload" reduced.

wp-graphql · Aug 5, 2020 · d79c730 · d79c730
1 parent 4523c87
commit d79c730
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/includes/mutation/class-cart-add-item.php b/includes/mutation/class-cart-add-item.php
@@ -106,17 +106,18 @@ public static function mutate_and_get_payload( $input, AppContext $context, Reso
 		// Add item to cart and get item key.
 		$cart_item_key = \WC()->cart->add_to_cart( ...$cart_item_args );
 
-		if ( false ===  $cart_item_key ) {
-			$notices = \WC()->session->get( 'wc_notices' );
-			if ( ! empty( $notices['error'] ) ) {
-				$cart_error_messages = implode( ' ', array_column( $notices['error'], 'notice' ) );
-				throw new UserError( $cart_error_messages );
-			} else {
-				throw new UserError( __( 'Failed to add cart item. Please check input.', 'wp-graphql-woocommerce' ) );
-			}
+		// If cart item key valid return payload.
+		if ( false !==  $cart_item_key ) {
+			return array( 'key' => $cart_item_key );
 		}
 
-		// Return payload.
-		return array( 'key' => $cart_item_key );
+		// Process errors.
+		$notices = \WC()->session->get( 'wc_notices' );
+		if ( ! empty( $notices['error'] ) ) {
+			$cart_error_messages = implode( ' ', array_column( $notices['error'], 'notice' ) );
+			throw new UserError( $cart_error_messages );
+		} else {
+			throw new UserError( __( 'Failed to add cart item. Please check input.', 'wp-graphql-woocommerce' ) );
+		}
 	}
 }