Avoid PHP deprecation notices in PHP 8.1.x#5899
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom Feb 10, 2024
Merged
Conversation
swissspidy
approved these changes
Feb 8, 2024
Contributor
Author
|
@schlessera Little bit sad I didn't get the "WP-CLI Contributor" badge on my wporg profile for this and #5897 🤷 Ah well. |
Member
|
@christianwach These badges are not granted automatically and we do not have the capacity nor technical ability to find everyone's WordPress.org profile and assign badges ourselves. You can however request a badge at https://profiles.wordpress.org/associations/cli-contributor/request-membership/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #5898 for details.
tl;dr In versions of PHP greater than 8.1.x, when
Utils\http_request()fails, thenPHP Deprecatednotices are written to the logs. Passing(int) 0is compatible with the signature of theRuntimeExceptionconstructor and avoids the warnings.Since there are no functional changes in this PR, I haven't included tests.