Avoid deprecation warnings in newer PHP#185
Merged
swissspidy merged 1 commit intomasterfrom Mar 26, 2025
Merged
Conversation
To avoid deprecation warnings in newer PHP: ``` PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /Users/isla/source/wp-cli-dev/php-cli-tools/lib/cli/table/Tabular.php on line 30 ```
414e72a to
854de46
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
swissspidy
approved these changes
Mar 26, 2025
Member
swissspidy
left a comment
There was a problem hiding this comment.
Good find, thanks! Appreciate the added test, as the existing tests didn't cover this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid deprecation warnings in PHP 8.1+:
I saw this while running tests for wp-cli/package-command#197 where some rows of
wp package browselook like: