-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and combine theme.json
and block.json
extractors
#319
Conversation
cc @gziolo |
Looks like the existing theme i18n schema parser does not support cases like "keywords": [ "block keyword" ], as seen in So that needs some fiddling to enable support and make the tests pass |
@schlessera I'm running into some fatal errors here on PHP < 7.4. Perhaps you have some ideas here? Not sure which one of my changes could have caused that... |
@swissspidy The problem was the use of |
Ah 💡 🤦 Thanks! |
theme.json
and block.json
extractors
I think it's a good idea to use the file from Anyway, it looks like this PR has everything covered. Nice work, thank you for bringing i18n schemas up to date ❤️ |
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Uses the
block-i18n.json
schema file to determine which fields are translatable.Enhancement: Adds support for translating block variation fields. Apparently these were not extracted before...
Fixes #287