wrong exit code by updating plugin

@unclesamwk commented on Oct 25, 2018, 10:02 PM UTC:

Hey,

i use wpcli und i've got an error by updating an plugin but exitcode is 0 not 1.

root:/html/wordpress > php_cli /tmp/wp plugin update onepress-plus --quiet
+---------------+-------------+-------------+--------+
| name          | old_version | new_version | status |
+---------------+-------------+-------------+--------+
| onepress-plus | 2.0.6       | 2.1.2       | Error  |
+---------------+-------------+-------------+--------+
root:/html/wordpress > echo $?
0

its a bug?

greetings
sam

This issue was moved by schlessera from wp-cli/wp-cli#4983.

[schlessera]

The string Error that you see in the right-most column does not come from WP-CLI itself.

My first guess would be that the plugin does something weird with a custom update mechanism (it seems to be a premium plugin not hosting in the official plugin repository), and that it returns the string Error while not actually producing a return code that signifies an error happened.

Would you be able to fetch the network requests that are being done when trying this update? This help find out what the reason is for this behavior and maybe fix it.

[schlessera]

This should be fixed by #143