Allow deleting multiple options at once #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrijith
changed the title
thrijith
approved these changes
Apr 18, 2019
Member
thrijith
left a comment
thrijith
left a comment
There was a problem hiding this comment.
LGTM, @schlessera Could you please take a look? Thanks.
schlessera
requested changes
Apr 18, 2019
Member
schlessera
left a comment
schlessera
left a comment
There was a problem hiding this comment.
Only a minor nitpick, I always prefer to have curly braces around variable substitution, as that habit makes broken substitutions impossible (where the variable name is immediately followed by other text) and is visually clearer.
schlessera
approved these changes
Apr 20, 2019
Member
|
Thanks for the PR, @Sidsector9 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #220
Adds the feature to delete multiple options at once by running a foreach loop on the arguments.