Skip to content

Conversation

@Mte90
Copy link
Contributor

@Mte90 Mte90 commented Feb 13, 2019

The new command is avalaible!

I need only to do the unit tests but I will work on them but before to do that I want a feedback about the warning in the code.

Example output:

Post 218854 assigned to new term!
Post 218860 assigned to new term!
Post 218870 assigned to new term!
Post 218879 assigned to new term!
Post 218892 assigned to new term!
Post 218893 assigned to new term!
Post 218903 assigned to new term!
Post 218913 assigned to new term!
Post 218922 assigned to new term!
Post 218957 assigned to new term!
Post 218974 assigned to new term!
Post 218995 assigned to new term!
Post 219050 assigned to new term!
Post 219060 assigned to new term!
Term migrated!
Old Term removed!
Success: Migration of `9190` term for 5494 posts

@desrosj desrosj added the command:taxonomy Related to 'taxonomy' command label Feb 15, 2019
@desrosj
Copy link
Member

desrosj commented Feb 15, 2019

@Mte90 Are you able to write some tests for this?

@desrosj desrosj added command:term Related to 'term' command and removed command:taxonomy Related to 'taxonomy' command labels Feb 15, 2019
@Mte90
Copy link
Contributor Author

Mte90 commented Feb 15, 2019

Yes I can do it but I am not sure about the warning (specifically about the text messages) printed in the console.

@schlessera
Copy link
Member

Let me do a quick review of the text messages then so you now what final strings to test against...

schlessera and others added 2 commits February 19, 2019 18:22
Co-Authored-By: Mte90 <mte90net@gmail.com>
@Mte90
Copy link
Contributor Author

Mte90 commented Feb 19, 2019

I will work on the other changes and tests in the next days.

Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small string changes, and then we're good to merge.

apply second review

Co-Authored-By: Mte90 <mte90net@gmail.com>
@schlessera schlessera added this to the 2.0.3 milestone Feb 24, 2019
@schlessera schlessera merged commit 6132db5 into wp-cli:master Feb 24, 2019
@schlessera
Copy link
Member

Thanks for the PR, @Mte90!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:term Related to 'term' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants