Skip to content

Check for STDIN if --post_content is used #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 5 commits into from
Apr 20, 2019
Merged

Check for STDIN if --post_content is used #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24dec4a
fix #175
Mte90 Jul 20, 2018
c286afe
rewriting to optimize
Mte90 Jul 20, 2018
ee7fe25
Merge branch 'master' into stdin
schlessera Dec 3, 2018
7bca56c
Avoid unneeded empty check, flags return booleans
schlessera Dec 3, 2018
3a40f0c
Mark test as @broken for now
schlessera Apr 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions features/post-generate.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ Feature: Generate new WordPress posts
"""
And STDERR should be empty

@broken
Scenario: Using --post-content requires STDIN input
When I try `wp post generate --count=1 --post_content`
Then STDERR should contain:
"""
Error: The parameter `post_content` reads from STDIN.
"""

Scenario: Generating posts by a specific author

When I run `wp user create dummyuser dummy@example.com --porcelain`
Expand Down
4 changes: 4 additions & 0 deletions src/Post_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,10 @@ public function generate( $args, $assoc_args ) {
}

if ( \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) {
if ( ! \WP_CLI\Entity\Utils::has_stdin() ) {
WP_CLI::error( 'The parameter `post_content` reads from STDIN.' );
}

$post_content = file_get_contents( 'php://stdin' );
}

Expand Down