Add dbuser/dbpass options to privileged commands. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
requested changes
Jan 5, 2018
src/DB_Command.php
Outdated
| * ## OPTIONS | ||
| * | ||
| * [--dbuser=<value>] | ||
| * : Username to pass to mysqlcheck. Defaults to DB_USER. |
src/DB_Command.php
Outdated
| * : Username to pass to mysqlcheck. Defaults to DB_USER. | ||
| * | ||
| * [--dbpass=<value>] | ||
| * : Password to pass to mysqlcheck. Defaults to DB_PASSWORD. |
src/DB_Command.php
Outdated
| * ## OPTIONS | ||
| * | ||
| * [--dbuser=<value>] | ||
| * : Username to pass to mysqlcheck. Defaults to DB_USER. |
src/DB_Command.php
Outdated
| * : Username to pass to mysqlcheck. Defaults to DB_USER. | ||
| * | ||
| * [--dbpass=<value>] | ||
| * : Password to pass to mysqlcheck. Defaults to DB_PASSWORD. |
src/DB_Command.php
Outdated
| * ## OPTIONS | ||
| * | ||
| * [--dbuser=<value>] | ||
| * : Username to pass to mysqlcheck. Defaults to DB_USER. |
src/DB_Command.php
Outdated
| * : Username to pass to mysqlcheck. Defaults to DB_USER. | ||
| * | ||
| * [--dbpass=<value>] | ||
| * : Password to pass to mysqlcheck. Defaults to DB_PASSWORD. |
src/DB_Command.php
Outdated
| * : Use a specific character set. Defaults to DB_CHARSET when defined. | ||
| * | ||
| * [--dbuser=<value>] | ||
| * : Username to pass to the MySQL executable. Defaults to DB_USER. |
There was a problem hiding this comment.
the MySQL executable => mysql, to stay consistent with all of the other docblocks.
src/DB_Command.php
Outdated
| * : Username to pass to the MySQL executable. Defaults to DB_USER. | ||
| * | ||
| * [--dbpass=<value>] | ||
| * : Password to pass to the MySQL executable. Defaults to DB_PASSWORD. |
There was a problem hiding this comment.
the MySQL executable => mysql, to stay consistent with all of the other docblocks.
schlessera
approved these changes
Jan 5, 2018
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Add dbuser/dbpass options to privileged commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74
Adds dbuser/dbpass options to all the heightened privilege commands, ie all except
prefix,search,sizeandtables.Also adds extra arguments option to
check,optimizeandrepairfor consistency with most of the other privileged commands.