Skip to content

Conversation

@jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 21, 2019

  • Make namespace prefix configuration consistent with other repos.
  • Don't use a leading backslash in use statements.
  • Actually make use of the use statement.
  • Add a missing whitelist explanation.
  • Fix indentation of two comments.

Follow-up on #141
Related to #139, wp-cli/wp-cli#5179

@jrfnl jrfnl requested a review from a team as a code owner April 21, 2019 03:32
@jrfnl jrfnl force-pushed the feature/minor-cs-tweaks branch from 75da3c7 to 9049d20 Compare April 21, 2019 03:41
* Make namespace prefix configuration consistent with other repos.
* Don't use a leading backslash in `use` statements.
* Actually make use of the `use` statement.
* Add a missing whitelist explanation.
* Fix indentation of two comments.
@schlessera schlessera merged commit dd5f253 into wp-cli:master Apr 21, 2019
@schlessera schlessera added this to the 2.0.2 milestone Apr 21, 2019
@jrfnl jrfnl deleted the feature/minor-cs-tweaks branch April 21, 2019 11:37
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants