Skip to content

Conversation

@swissspidy
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 12, 2026 13:21
@swissspidy swissspidy requested a review from a team as a code owner February 12, 2026 13:21
@gemini-code-assist
Copy link

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves static analysis warnings reported by PHPStan by refining the argument handling for WordPress cron scheduling. The change ensures that arguments passed to wp_schedule_event and wp_schedule_single_event are consistently ordered and numerically indexed, leading to more robust and error-free cron job scheduling.

Highlights

  • PHPStan Error Resolution: Addressed newly reported PHPStan errors by modifying how arguments are prepared for WordPress cron scheduling functions.
  • Argument Preparation Logic: Implemented a step to sort associative arguments by key and then re-index them numerically before passing them to wp_schedule_event and wp_schedule_single_event.
Changelog
  • src/Cron_Event_Command.php
    • Modified the argument preparation logic for wp_schedule_event and wp_schedule_single_event to sort and re-index associative arguments.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix PHPStan errors by ensuring that arguments passed to cron scheduling functions are correctly formatted as a list. While the change is a good step, it could inadvertently include non-numeric associative arguments in the cron job's parameters. I've provided a suggestion to filter these out, ensuring only the intended numeric-keyed arguments are passed to the cron hook.

@github-actions
Copy link

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts wp cron event schedule argument handling to satisfy stricter PHPStan expectations by ensuring cron hook arguments are passed as a numerically indexed list (as WP-Cron expects for do_action_ref_array() style invocation).

Changes:

  • Normalize hook arguments by sorting CLI-provided keys and reindexing to a list.
  • Pass the normalized argument list to wp_schedule_event() / wp_schedule_single_event().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 188 to 191
$cron_args = $assoc_args;
ksort( $cron_args );
$cron_args = array_values( $cron_args );

Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new normalization of hook arguments (sorting by key and reindexing with array_values) changes behavior when users pass numeric arguments out of order (e.g. --1=... --0=...). There’s existing Behat coverage for scheduling with args, but it doesn’t assert this normalization behavior; please add/extend a functional scenario to cover ordering normalization so regressions are caught.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.3.4 milestone Feb 13, 2026
@swissspidy swissspidy merged commit 55df518 into main Feb 13, 2026
53 checks passed
@swissspidy swissspidy deleted the fix-phpstan branch February 13, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant