Skip to content

Conversation

@danielbachhuber
Copy link
Member

  • Cleanup tests for greater specificity.
  • Move errors to an earlier position to prevent unnecessary code execution.
  • Use the appropriate cache key name for --skip-content.
  • Avoid duplicate API requests by executing code path earlier.

Fixes #36

@danielbachhuber danielbachhuber added this to the 1.0.3 milestone Oct 1, 2017
@danielbachhuber danielbachhuber requested a review from a team October 1, 2017 13:51
@danielbachhuber
Copy link
Member Author

@AaronRutley ^ Worth looking through those changes to see the cleanup I did.

@AaronRutley
Copy link

@danielbachhuber! I've just had a look over your cleanup commits, it all makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants