`wp admin` does not support Windows

[dgrfdsgn]

Windows 10, WP CLI

wp admin --info 'xdg-open' is not recognized as an internal or external command, operable program or batch file.

So what's going wrong, how can i get the wp admin command to run? btw, im running WP-CLI 2.0.1 on win10 from powershell. Any help would be greatly appreciated.

Stackexchange brought me here

[schlessera]

Indeed, as stated on StackExchange, Windows is not yet supported by this command.

I'm open to accepting a pull request to add Windows support, I am not able to test this myself, though.

[schlessera]

A quick search seems to confirm that it should just be a matter of using start on Windows.

[dgrfdsgn]

Im able to test if u want?

[schlessera]

@dgrfdsgn Yes, that would be great. I'll look into doing a PR myself later this week.

[dgrfdsgn]

@schlessera Is this the commit you want me to test or?

[schlessera]

@dgrfdsgn Yes, this should fix it for Windows.

[dgrfdsgn]

confirmed after manual install, this now opens a cmd / PS in the WordPress directory, but nothing else.
start is working now, but no browser opened. @schlessera @kingkero

[dgrfdsgn]

@schlessera @kingkero Example, im in ~/wp_1/ and perform wp admin, the powershell is opened in ~/wp_1/ although the title says http://localhost/wp_1/wp-admin/ and you're supposed to see a browser open

[schlessera]

@dgrfdsgn Thanks for testing and the feedback! I'll look further into this.

[kingkero]

Just got my hands on a Win10. Tried the following in default cmd

• start "example.com", opens a new cmd with the URL as title (as dgrdsgn mentioned)
• start 'example.com', gives an error
• start example.com, opens the user's default browser.

So the URL needs not to be quoted. However, escapeshellarg() will add double-quotes to strings on Windows. What do you think is the best way to move forwared here, @schlessera ?