Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Bootstrap 5 support #531

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

IanDelMar
Copy link
Collaborator

@IanDelMar IanDelMar commented Nov 9, 2021

This PR adds basic Bootstrap 5 support to the walker.

Fixes #528

Changes proposed in this Pull Request:

  • Adds the possibility to request Bootstrap 5 markup via the arguments passed to the wp_nav_menu() function.
  • Adds the bs infix to data attributes if Bootstrap 5 markup is requested.
  • Adds the .active class to the a element instead of the li element if Bootstrap 5 markup is requested.

Proposed changelog entry for your changes:

Add basic Bootstrap 5 support

Notes:

Related issues and PRs:

#499, #513, #500

@IanDelMar IanDelMar changed the title Add Bootstrap 5 support [WIP] Add Bootstrap 5 support Nov 12, 2021
@ethanclevenger91
Copy link

@IanDelMar What's the status of this PR? You seem fairly interested in maintenance on this project. Would it be worth a maintained fork for BS5 and continued development? Unless @pattonwebz has plans to return to this.

@leqnam
Copy link

leqnam commented Jun 4, 2023

This PR should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active Class Font Color Not Working
3 participants