Skip to content

Add grey out setting - #17

Merged
woutdp merged 13 commits into
woutdp:masterfrom
jchanke:add-grey-out-setting
Oct 4, 2025
Merged

Add grey out setting#17
woutdp merged 13 commits into
woutdp:masterfrom
jchanke:add-grey-out-setting

Conversation

@jchanke

@jchanke jchanke commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

add a new user setting to not grey-out countries/cities already found. addresses issue #16.

organized this into 5 tiny changes:

  • ab0d441 adds an option to SettingsMenu, coupled to the local store via localStorageWriteable
  • 72a8225 updates game logic to handle option
  • a21e0db renames 'unfoundFeatures' -> 'activeFeatures' (the countries/cities that are clickable & in color), since after the update, some already-found features are still 'active'
  • ce4883c adds the ui to notify the user if the country is already found
  • 25692e4 this is up to you: if the user clicks on an already-found feature, should it count as a new mistake?

thanks so much for reviewing this! :)

@jchanke
jchanke marked this pull request as ready for review July 2, 2025 02:13
@SpirioSpirio

Copy link
Copy Markdown

Do you see you can review it @woutdp in a near future? 🙏

@woutdp
woutdp force-pushed the add-grey-out-setting branch from 25692e4 to a5a41b2 Compare October 4, 2025 20:03
@woutdp
woutdp merged commit 9f5e534 into woutdp:master Oct 4, 2025
@woutdp

woutdp commented Oct 4, 2025

Copy link
Copy Markdown
Owner

Thank you! And thank you for the coffee :)

@woutdp

woutdp commented Oct 4, 2025

Copy link
Copy Markdown
Owner

The new maps cause the build to exceed 25mb, which is the limit for cloudflare pages. So I need to move some stuff to an R2 bucket to make it work. So we'll be on the previous version for a little bit until I figure that one out

@jchanke
jchanke deleted the add-grey-out-setting branch December 21, 2025 07:13
@jchanke

jchanke commented Dec 21, 2025

Copy link
Copy Markdown
Contributor Author

Just saw this: thank you so much, @woutdp! :)

@SpirioSpirio

Copy link
Copy Markdown

Just saw this: thank you so much, @woutdp! :)

But we can't access the version with the merge, or I didn't find how 😢

@woutdp

woutdp commented Dec 23, 2025

Copy link
Copy Markdown
Owner

I couldn't figure out how to deploy the latest version unfortunately and haven't spend too much time trying to make it work. Might invest some more time at some point. Feel free to deploy this anywhere btw I want people to enjoy the game so you have my permission if you'd like to do that :)

@SpirioSpirio

Copy link
Copy Markdown

I couldn't figure out how to deploy the latest version unfortunately and haven't spend too much time trying to make it work. Might invest some more time at some point. Feel free to deploy this anywhere btw I want people to enjoy the game so you have my permission if you'd like to do that :)

Thank you! I didn't find how to find a branch with the last features merged. Could you create one?

@woutdp

woutdp commented Dec 23, 2025

Copy link
Copy Markdown
Owner

It should be the master branch of this project. You might need to pull in the changes or just do a new clone of the project.

@SpirioSpirio

Copy link
Copy Markdown

It should be the master branch of this project. You might need to pull in the changes or just do a new clone of the project.

It is not. I clone the repository, looked for commit and some modifications the pull request has done, no result :(

@woutdp

woutdp commented Dec 24, 2025

Copy link
Copy Markdown
Owner

Sorry I've made a mistake it's indeed not in master. I've created a new branch dev which now contains the changes :)

@jchanke
jchanke restored the add-grey-out-setting branch December 25, 2025 05:51
@SpirioSpirio

SpirioSpirio commented Dec 25, 2025

Copy link
Copy Markdown

Sorry I've made a mistake it's indeed not in master. I've created a new branch dev which now contains the changes :)

Thank you! I update the version available at https://geoquest.spirio.fr and the docker container too https://hub.docker.com/r/spiriospirio/geoquest/tags. Merry Christmas 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants