Add cleanup variable to verify function + cleanup command #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdebrauwer
requested changes
May 5, 2022
Comment on lines
8
to
12
| class CleanupVerificationCodesCommand extends Command | ||
| { | ||
| protected $signature = 'verification-code:cleanup {days : Codes older than these days will be deleted.}'; | ||
|
|
||
| protected $description = 'Remove verification code older than the given days.'; |
Contributor
There was a problem hiding this comment.
Suggested change
| class CleanupVerificationCodesCommand extends Command | |
| { | |
| protected $signature = 'verification-code:cleanup {days : Codes older than these days will be deleted.}'; | |
| protected $description = 'Remove verification code older than the given days.'; | |
| class PruneCommand extends Command | |
| { | |
| protected $signature = 'verification-code:prune {--hours=24 : The number of hours to retain verification codes}'; | |
| protected $description = 'Prune old verification codes'; |
I would set it up similarly to the prune command of Telescope (https://github.com/laravel/telescope/blob/4.x/src/Console/PruneCommand.php)
src/VerificationCodeManager.php
Outdated
| * @return bool | ||
| */ | ||
| public function verify(string $code, string $verifiable) | ||
| public function verify(string $code, string $verifiable, bool $cleanup = true) |
Contributor
There was a problem hiding this comment.
On second thought, maybe we should call it $deleteAfterVerification 🤔 so there can not be any confusion about the meaning.
can you also document this extra option?
Comment on lines
18
to
20
| VerificationCode::query() | ||
| ->where('created_at', '<=', now()->subDays($days)) | ||
| ->delete(); |
Contributor
There was a problem hiding this comment.
Suggested change
| VerificationCode::query() | |
| ->where('created_at', '<=', now()->subDays($days)) | |
| ->delete(); | |
| VerificationCode::where('created_at', '<=', now()->subDays($days))->delete(); |
can be on one line
gdebrauwer
approved these changes
May 5, 2022
src/VerificationCodeManager.php
Outdated
| * | ||
| * @param string $code | ||
| * @param string $verifiable | ||
| * @param bool $cleanup |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param bool $cleanup | |
| * @param bool $deleteAfterVerification |
tests/Commands/PruneCommandTest.php
Outdated
|
|
||
| $this->artisan('verification-code:prune', ['--hours' => 3]); | ||
|
|
||
| $dbVerificationCode = VerificationCode::all(); |
Contributor
There was a problem hiding this comment.
Suggested change
| $dbVerificationCode = VerificationCode::all(); | |
| $dbVerificationCodes = VerificationCode::all(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 #21