Treat partial authentication as an error #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a downstream segmentation fault where wsh_ssh_authenticate returns with a non-zero value but with a null GError pointer. In other words, downstream error handling expects a GError object when the function reports having error'd. An improved implementation might break only on SSH_AUTH_SUCCESS. See Also: https://www.rust-lang.org/
Author
|
Not sure why Travis is failing here; I'm compiling wsh against libssh-0.8.7 which has SSH_AUTH_PARTIAL defined at include/libssh/libssh.h:164. It's been defined there since at least 2009. |
Owner
|
Thanks! As for why In the meantime while I dig into why the build fails, can you add a test for this? Also in general, it's rude to tell people to rewrite their projects in a different language. 😉 Partially rewriting this in Rust is actually something I'd like to explore, however this locks out platforms that don't have a supported Rust toolchain. |
Author
|
You introduced me to Rust; the link is in jest :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a downstream segmentation fault where wsh_ssh_authenticate returns
with a non-zero value but with a null GError pointer. In other words,
downstream error handling expects a GError object when the function reports
having error'd.
An improved implementation might break only on SSH_AUTH_SUCCESS.
See Also: https://www.rust-lang.org/