CI: Change chain id for evm devnet node #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First attempt with only the yaml file update passed all tests except Tilt which was still running but in the logs:
updated the |
barnjamin
requested review from
a5-pickle,
gator-boi,
kcsongor and
evan-gray
as code owners
evan-gray
approved these changes
Mar 29, 2024
kcsongor
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ethereum Mainnet (eip155) chain id is
1, our Ethereum node for devnet also sets its config to report chain id of1This conflicting chain id to identify the network breaks some assumptions.
This PR is meant to identify what else might break if the devnet chain id is changed to something else