Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node/CCQServer: log responses #3752

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Node/CCQServer: log responses #3752

merged 1 commit into from
Jan 29, 2024

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Jan 29, 2024

This PR adds the ability to log query responses for a given user, as enabled in the JSON file. It uses a map to track the in progress queries for which logging is enabled. Since we don't know when a query is complete (We don't just want to stop logging when quorum is reached), queries stay in the map for two minutes before being automatically cleaned up. The timer is set to two minutes since a query times out after one minute.

Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@bruce-riley bruce-riley marked this pull request as ready for review January 29, 2024 19:20
Copy link
Contributor

@panoel panoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging Map only logs the most recent 2 minutes requests? A request can go longer than 2 minutes but just won't get logged?

@bruce-riley bruce-riley merged commit e98bb64 into main Jan 29, 2024
22 checks passed
@bruce-riley bruce-riley deleted the ccqserver_log_responses branch January 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants