Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum: PUSH0 test #3748

Merged
merged 2 commits into from
Jan 30, 2024
Merged

ethereum: PUSH0 test #3748

merged 2 commits into from
Jan 30, 2024

Conversation

djb15
Copy link
Collaborator

@djb15 djb15 commented Jan 26, 2024

Checks that we don't inadvertently build contracts with compiler versions that support PUSH0 opcodes whilst support is spotty.

It's brittle but it works whilst this is a transient state of play.

ethereum/Makefile Outdated Show resolved Hide resolved
kcsongor
kcsongor previously approved these changes Jan 26, 2024
Copy link
Contributor

@kcsongor kcsongor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@djb15 djb15 force-pushed the ethereum/push0-test branch from 5bd273d to 9406a48 Compare January 27, 2024 06:15
@djb15 djb15 force-pushed the ethereum/push0-test branch from 9406a48 to 2f4656e Compare January 30, 2024 18:42
@evan-gray evan-gray merged commit bf67227 into main Jan 30, 2024
22 checks passed
@evan-gray evan-gray deleted the ethereum/push0-test branch January 30, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants