-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node/CCQ: Solana min context slot support #3747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b74e67
to
251eae5
Compare
panoel
reviewed
Jan 26, 2024
panoel
reviewed
Jan 26, 2024
panoel
reviewed
Jan 26, 2024
evan-gray
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall I think this is an improvement and the structure is good, just a couple nits
panoel
reviewed
Jan 26, 2024
251eae5
to
400e0b0
Compare
panoel
previously approved these changes
Jan 26, 2024
6b840d5
to
9e283db
Compare
panoel
previously approved these changes
Jan 26, 2024
evan-gray
previously approved these changes
Jan 26, 2024
panoel
approved these changes
Jan 26, 2024
evan-gray
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fast retry mechanism to the Solana query handler when the RPC call fails due to the
MinContextSlot
not being met. In that case, we retry every 200 milliseconds, attempting to hit the desired slot.This PR also changes the query audit interval to once per second from every ten seconds so that we will be more likely to retry a query every ten seconds.