Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node/CCQ: Solana min context slot support #3747

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Jan 26, 2024

This PR adds a fast retry mechanism to the Solana query handler when the RPC call fails due to the MinContextSlot not being met. In that case, we retry every 200 milliseconds, attempting to hit the desired slot.

This PR also changes the query audit interval to once per second from every ten seconds so that we will be more likely to retry a query every ten seconds.

@bruce-riley bruce-riley force-pushed the node/ccq_solana_min_context_slot_retry branch 5 times, most recently from 9b74e67 to 251eae5 Compare January 26, 2024 20:09
@bruce-riley bruce-riley marked this pull request as ready for review January 26, 2024 20:13
node/pkg/query/query.go Outdated Show resolved Hide resolved
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I think this is an improvement and the structure is good, just a couple nits

node/pkg/watchers/solana/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/ccq.go Show resolved Hide resolved
node/pkg/watchers/solana/ccq.go Show resolved Hide resolved
@bruce-riley bruce-riley force-pushed the node/ccq_solana_min_context_slot_retry branch from 251eae5 to 400e0b0 Compare January 26, 2024 20:43
panoel
panoel previously approved these changes Jan 26, 2024
@bruce-riley bruce-riley force-pushed the node/ccq_solana_min_context_slot_retry branch from 6b840d5 to 9e283db Compare January 26, 2024 21:11
panoel
panoel previously approved these changes Jan 26, 2024
evan-gray
evan-gray previously approved these changes Jan 26, 2024
sdk/js-query/src/query/solana.test.ts Outdated Show resolved Hide resolved
node/pkg/watchers/solana/ccq.go Show resolved Hide resolved
@bruce-riley bruce-riley dismissed stale reviews from evan-gray and panoel via 9eb7900 January 26, 2024 22:03
@panoel panoel requested a review from evan-gray January 26, 2024 22:36
@bruce-riley bruce-riley merged commit 10b83f7 into main Jan 27, 2024
22 checks passed
@bruce-riley bruce-riley deleted the node/ccq_solana_min_context_slot_retry branch January 27, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants