CCQ: Testing #3424
Merged
CCQ: Testing #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
CCQ/node/Guardian_Changes
branch
from
ae39d94 to
24dbcdb
Compare
bruce-riley
force-pushed
the
CCQ/Testing
branch
from
2e24f36 to
8f10a69
Compare
bruce-riley
changed the base branch from
CCQ/node/Guardian_Changes
to
CCQ/Query_Server
bruce-riley
force-pushed
the
CCQ/Testing
branch
from
8f10a69 to
aac0af3
Compare
bruce-riley
requested review from
evan-gray,
kev1n-peters and
panoel
as code owners
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
2 times, most recently
from
6e07adc to
5071a05
Compare
SEJeff
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Questions
- Do you forsee a user having multiple api keys? If not, is the username for anything other than a description?
- Public facing code really needs better test coverage. Public facing == threat surface.
- Assuming its identity key is permissioned, does the query server need to run on a guardian?
Notes
- The all or nothing approach makes me uneasy for some reason. What if the user is ok with some of the queries failing? They just make 1 ccq for each query instead of batching them? This should be made obvious to integrators I think if it isn't blatantly obvious in the whitepaper and godoc comments.
- Try to avoid logging secrets as logs have a habit of being shared with the world sometimes on purpose and often by accident.
- Littering the key files all over the codebase is messy, it would be so awesome to just use interfaces so this code can be tested without requiring these. This is guaranteed 100% to result in extra immunefi bugs and nonsense from github code scanners that will waste our time.
- The guardianset is fetched on startup, but doesn't seem to be polled intermittently though there is a crasher error for the error when the gst might be wrong.
- This PR supercedes CCQ/Node: Guardian Changes #3423 because it includes the same commit.
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
c9337bc to
93b59cf
Compare
SEJeff
force-pushed
the
CCQ/Query_Server
branch
from
ec08acb to
295376f
Compare
bruce-riley
force-pushed
the
CCQ/Testing
branch
from
aac0af3 to
cf88129
Compare
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
295376f to
301601c
Compare
bruce-riley
force-pushed
the
CCQ/Testing
branch
from
99de9aa to
f7da688
Compare
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
301601c to
b5d8ffe
Compare
bruce-riley
force-pushed
the
CCQ/Testing
branch
from
f7da688 to
25dec86
Compare
evan-gray
approved these changes
Oct 12, 2023
SEJeff
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the CCQ feature. This PR is dependent on PR #3423.
For background on this feature see the whitepaper (PR #3418).