refund instead of revert for replay protection #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derpy-duck
force-pushed
the
auto-relayer/v1.1
branch
from
afbdf5d to
8e341ee
Compare
derpy-duck
requested review from
evan-gray,
kev1n-peters,
barnjamin,
a5-pickle,
gator-boi and
kcsongor
as code owners
derpy-duck
force-pushed
the
auto-relayer-1.1-refund-user-instead-of-revert-replay-protection
branch
from
0677100 to
6cb4a1c
Compare
JoeHowarth
reviewed
Sep 18, 2023
| DeliveryResults memory results; | ||
|
|
||
| // Check replay protection - if so, set status to receiver failure | ||
| if(getDeliverySuccessState().deliverySuccessBlock[vaaInfo.deliveryVaaHash] != 0) { |
There was a problem hiding this comment.
I checked and didn't see an issue, but flagging that it makes me slightly nervous that now we're not checking replay protection until this point in code
JoeHowarth
approved these changes
Sep 18, 2023
JoeHowarth
deleted the
auto-relayer-1.1-refund-user-instead-of-revert-replay-protection
branch
derpy-duck
added a commit
that referenced
this pull request
Sep 21, 2023
* refund instead of revert for replay protection * Remove mention of forward from IWormholeReceiver
derpy-duck
added a commit
that referenced
this pull request
Sep 22, 2023
* refund instead of revert for replay protection * Remove mention of forward from IWormholeReceiver
derpy-duck
added a commit
that referenced
this pull request
Sep 22, 2023
* AutoRelayer: remove forwards * AutoRelayer: reentrancy guard * AutoRelayer: remove forwards from sdk * AutoRelayer: VaaKey -> MessageKey internals * AutoRelayer: check delivery provider supports keyType * AutoRelayer: VaaKey backcompat wire format * AutoRelayer: sdk fix * AutoRelayer: Add supported keys to delivery provider * AutoRelayer: reintroduce reentrancy guard, revert when replay protection triggered * AutoRelayer: fix manual delivery test * AutoRelayer: review flups * AutoRelayer: move libraries within relayer folder * AutoRelayer: fix delivery provider config script Also fix delivery provider revert bug * AutoRelayer: Andreas code review flups * AutoRelayer: js sdk includes MessageKey serde * AutoRelayer: update sdk to use message key * AutoRelayer: Simplify executeInstruction to internal call (#3352) * refund instead of revert for replay protection (#3371) * refund instead of revert for replay protection * Remove mention of forward from IWormholeReceiver * AutoRelayer: 1.1 reintroduce forwards (#3385) * forward fallback WIP * forward fallback no tmp storage * Re-introduce testing of 'forward' * Reintroduce forwards with original or default behavior for refund info + delivery provider info * Reintroduce reentrant, only store refund information --------- Co-authored-by: Joe Howarth <josephehowarth@gmail.com> Co-authored-by: Joe Howarth <jhowarth@jumptrading.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.