Node/Gateway: Wormconn chainID wrong for testnet #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
requested review from
panoel,
kev1n-peters and
evan-gray
as code owners
panoel
reviewed
Aug 23, 2023
panoel
approved these changes
Aug 23, 2023
evan-gray
approved these changes
Aug 23, 2023
nik-suri
approved these changes
Aug 23, 2023
bruce-riley
deleted the
node/gateway_wormconn_chainid_wrong_for_testnet
branch
This was referenced Jan 5, 2024
Merged
This was referenced Oct 11, 2024
This was referenced Oct 18, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChainID parameter on wormchain transactions is hardcoded to be "wormchain". However, in testnet it should be "wormchain-testnet-0".