node: move adminrpc from guardiand into own package #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbjump
requested review from
bruce-riley,
panoel,
kev1n-peters,
evan-gray and
hendrikhofstadt
as code owners
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
tbjump
force-pushed
the
05-24-node_move_adminrpc_from_guardiand_into_own_package
branch
from
8607ba2 to
1ed9cfc
Compare
|
restacked and ready for review |
bruce-riley
reviewed
Jun 1, 2023
11 tasks
tbjump
force-pushed
the
05-24-node_move_adminrpc_from_guardiand_into_own_package
branch
from
1ed9cfc to
18df15a
Compare
bruce-riley
approved these changes
Jun 5, 2023
SEJeff
approved these changes
Jun 6, 2023
|
@SEJeff I'll leave your feedback on the code here unaddressed since this PR is solely about moving things around without changing anything but we can pick this up again in a follow-up PR. |
tbjump
deleted the
05-24-node_move_adminrpc_from_guardiand_into_own_package
branch
tbjump
pushed a commit
that referenced
this pull request
Jun 8, 2023
evan-gray
pushed a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, only refactoring.
This PR moves the adminserver into its own package.
Context: this is part of cleaning up the guardiand package to make it more testable (more PRs coming).
The adminserver could use some cleanup and refactoring as well, but this is out of scope of this PR.