Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitepapers: Update Governor whitepaper #2401

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

tbjump
Copy link
Contributor

@tbjump tbjump commented Feb 17, 2023

  • expand section explaining the reasons for defense-in-depth
  • add clarity around limit vs. delay
  • add FAQ section

bruce-riley
bruce-riley previously approved these changes Feb 21, 2023
whitepapers/0007_governor.md Outdated Show resolved Hide resolved
whitepapers/0007_governor.md Outdated Show resolved Hide resolved
whitepapers/0007_governor.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these types of FAQs live in a design doc. They are probably a better fit for documentation as they just restate the more technical explanation in layman's terms

bruce-riley
bruce-riley previously approved these changes Feb 27, 2023
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to @hendrikhofstadt 's comment, I just enabled the wiki feature, perhaps that will be a good home for a plain english description of features.

@tbjump
Copy link
Contributor Author

tbjump commented Aug 25, 2023

Addressed reviewer feedback: Removed the FAQ section

@evan-gray evan-gray merged commit 5776088 into main Sep 1, 2023
@evan-gray evan-gray deleted the tbjump/governor-whitepaper2 branch September 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants