Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Fix defer #2334

Merged
merged 2 commits into from
Feb 6, 2023
Merged

node: Fix defer #2334

merged 2 commits into from
Feb 6, 2023

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Feb 3, 2023

It looks like the defer wasn't working as intended.

@bruce-riley bruce-riley marked this pull request as draft February 4, 2023 01:35
@bruce-riley bruce-riley marked this pull request as ready for review February 5, 2023 13:39
jynnantonix
jynnantonix previously approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jynnantonix jynnantonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Looks good to me once Bruce's comment is addressed.

node/pkg/watchers/solana/client.go Show resolved Hide resolved
hendrikhofstadt
hendrikhofstadt approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Chirantan

@panoel panoel merged commit d8f4740 into main Feb 6, 2023
@panoel panoel deleted the solana_watcher_leak branch February 6, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikhofstadt hendrikhofstadt hendrikhofstadt approved these changes

@jumpsiegel jumpsiegel jumpsiegel approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@jynnantonix jynnantonix jynnantonix left review comments

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panoel @jynnantonix @hendrikhofstadt @jumpsiegel @bruce-riley