Slightly less verbose guardian logging at info level #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEJeff
requested review from
hendrikhofstadt,
jumpsiegel,
bruce-riley,
evan-gray and
leoluk
as code owners
bruce-riley
previously approved these changes
Jan 25, 2023
hendrikhofstadt
previously approved these changes
Jan 26, 2023
SEJeff
force-pushed
the
excessive-watcher-logging-to-debug-yo
branch
from
5356197 to
f7b8100
Compare
justinschuldt
dismissed stale reviews from hendrikhofstadt and bruce-riley
via
f7b8100
evan-gray
force-pushed
the
excessive-watcher-logging-to-debug-yo
branch
from
f7b8100 to
53b0fe7
Compare
SEJeff
force-pushed
the
excessive-watcher-logging-to-debug-yo
branch
from
53b0fe7 to
9665ed2
Compare
evan-gray
force-pushed
the
excessive-watcher-logging-to-debug-yo
branch
from
9665ed2 to
669621b
Compare
It would be nice to redo this log entry to log something more human readable in addition to a json blob, but one thing at a time.
The near watcher logs when attempting to poll a block and when it successfully polls a block in addition to some metrics. These are useful logs, but more suited for debug loglevel.
This cuts down on an enormous amount of additional logging.
* Set some info logs to debug * Fix tyop of missmatch --> mismatch
SEJeff
force-pushed
the
excessive-watcher-logging-to-debug-yo
branch
from
669621b to
1590539
Compare
bruce-riley
approved these changes
Jan 30, 2023
hendrikhofstadt
approved these changes
Jan 30, 2023
jumpsiegel
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the first in what will likely be a series of changes to log less debugging information by default. Useful non-debug data should be returned from the guardian at the info log level.
I looked through each watcher by searching for
logger\.Infoand updating where it made sense.