Script to generate change registration governance #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If99e78b031dcd4049a9ee40b09914eeb93e7518a
panoel
reviewed
Sep 2, 2022
panoel
reviewed
Sep 2, 2022
panoel
reviewed
Sep 2, 2022
panoel
previously approved these changes
Sep 2, 2022
Change-Id: I93cf3166c1ab961add2c524084de1981a44b194e
kcsongor
previously approved these changes
Sep 5, 2022
Change-Id: Iae6f9854a64d8559d03c56949d03043a94dbf7f6
kcsongor
approved these changes
Sep 6, 2022
panoel
reviewed
Sep 6, 2022
panoel
approved these changes
Sep 6, 2022
evan-gray
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Script to generate change registration governance Change-Id: If99e78b031dcd4049a9ee40b09914eeb93e7518a * Rework from code review Change-Id: I93cf3166c1ab961add2c524084de1981a44b194e * Change chain_id to chain-id Change-Id: Iae6f9854a64d8559d03c56949d03043a94dbf7f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: If99e78b031dcd4049a9ee40b09914eeb93e7518a
Also changing the guardian verify VAA command to print the digest in the same format as the execute VAA command.
Much of the magic in register-chain-governance.sh was taken directly from contract-upgrade-governance.sh, which has previously been reviewed.