Skip to content

Conversation

@TooAngel
Copy link
Contributor

Summary

  • Update useAuth to fetch OAuth URL from /api/auth/url and redirect to GitHub
  • Add AuthCallback page to handle GitHub OAuth callback
  • Update proxy to set httpOnly cookie on /api/auth/callback response

This implements the client-side of the OAuth flow that works with the core's new API endpoints (TooAngel/worlddriven#328).

Flow

  1. User clicks "Login with GitHub"
  2. Frontend calls GET /api/auth/url?redirect_uri=<callback> to get OAuth URL
  3. Frontend redirects to GitHub OAuth
  4. GitHub redirects back to /auth/callback?code=xxx
  5. AuthCallback page calls POST /api/auth/callback with code
  6. Proxy sets httpOnly cookie from response
  7. User redirected to dashboard

Test plan

  • Click login button redirects to GitHub OAuth
  • After GitHub auth, user is redirected to dashboard
  • Session cookie is set correctly
  • Subsequent API calls are authenticated

- Update useAuth to fetch OAuth URL from /api/auth/url and redirect
- Add AuthCallback page to handle GitHub OAuth callback
- Update proxy to set httpOnly cookie on /api/auth/callback response

Works with core's new /api/auth/url and /api/auth/callback endpoints.
@worlddriven
Copy link

worlddriven bot commented Dec 23, 2025

🤖 Worlddriven Status

📊 Live Status Dashboard

🗓️ Merge Date: 2025-12-25 at 06:30:04 UTC (today)
📅 Started: 2025-12-23 at 06:30:04 UTC
Speed Factor: 0.20 (80% faster due to reviews)
Positive votes: 4/5 contribution weight (coefficient: 0.80)
📈 Base Merge Time: 10 days → Current: 2 days

🎯 Want to influence when this merges?

Your review matters! As a contributor to this project, your voice helps determine the merge timeline.

How to review:

  1. Check the changes
    Files changed

  2. Leave your review
    Review changes

Your options:

  • ✅ Agree & Speed Up: Approve Approving makes this merge faster
  • ❌ Disagree & Slow Down: Request changes Requesting changes delays the merge

💡 Pro tip: The more contributors who agree, the faster this gets merged!

📊 View detailed stats on the dashboard

📋 Recent Activity

2025-12-23, 06:30:12 - Pull request opened
2025-12-25, 06:51:34 - Pull request merged by worlddriven ✅


This comment is automatically updated by worlddriven

@worlddriven worlddriven bot merged commit b283356 into worlddriven:main Dec 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant