fix(types): Fix type errors with date-fns v4 #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkopitsa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect TypeScript type reference in the locale definition and date utils files that caused build errors when using the library with date-fns@4, Angular ≥ 18 and without
"skipLibCheck": truedate-fns@4 no longer exports Locale from date-fns/locale, TypeScript (and Angular’s ng-packagr) produce a type error during library build:
This happened because TypeScript inferred the type of the locale object (ru, de) from an internal Locale symbol inside date-fns/locale, which is not part of the public API.
Fixes #544