Convert context into query string for FGA queries #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkajla12
reviewed
Apr 30, 2025
| warrant_token="warrant_token", | ||
| context={"region": "us", "subscription": "pro"}, | ||
| ) | ||
| assert response.dict(exclude_none=True) == mock_query_response |
There was a problem hiding this comment.
Can we make an assertion on what the request URL looks like? (i.e. it should include a string-ified version of the JSON context)
atainter
approved these changes
Apr 30, 2025
stanleyphu
force-pushed
the
bug/convertQueryContextParam
branch
from
9a92b5d to
21e6f9d
Compare
kkajla12
approved these changes
May 1, 2025
gcarvelli
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the FGA
querymethod to convert thecontextparam from a dictionary to a string before making the request.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.