Add Directory Sync API and fix Audit Trail naming#18
Merged
rohanjadvani merged 3 commits intomasterfrom Apr 15, 2020
Merged
Conversation
rohanjadvani
force-pushed
the
rohanjadvani/dsync
branch
from
f93a0af to
686604a
Compare
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 96.35% 96.95% +0.60%
==========================================
Files 8 9 +1
Lines 137 164 +27
==========================================
+ Hits 132 159 +27
Misses 5 5
Continue to review full report at Codecov.
|
henrylamchan
approved these changes
Apr 15, 2020
Contributor
henrylamchan
left a comment
henrylamchan
left a comment
There was a problem hiding this comment.
LGTM. Would be nice to have docstrings on the Directory Sync methods though. I'm not familiar with the API and wasn't sure how the pagination works. Had to dig through the docs a bit to find out it was cursor based.
henrylamchan
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python wrappers for the API reference endpoints here.