Add email standard attribute to DirectoryUser and mark deprecated standard attributes #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndard attributes.
lib/Resource/DirectoryUser.php
Outdated
Comment on lines
19
to
22
| * @deprecated Will be removed in a future major version. | ||
| * Enable the `emails` custom attribute in dashboard and pull from customAttributes instead. | ||
| * See https://workos.com/docs/directory-sync/attributes/custom-attributes/auto-mapped-attributes for details. | ||
| */ |
Contributor
There was a problem hiding this comment.
It seems for PHP, you prefix the comment with [Deprecated] instead of @deprecated
Contributor
Author
There was a problem hiding this comment.
Oops, will update, thanks!
jonatascastro12
approved these changes
Mar 21, 2025
Contributor
jonatascastro12
left a comment
jonatascastro12
left a comment
There was a problem hiding this comment.
I think we just change from @deprecated to [Deprecated]. Other than that, it looks good to me.
mattgd
deleted the
feature/dsync-2750-add-email-attribute-to-directoryuser-in-php-sdk
branch
bradenkeith
pushed a commit
to bradenkeith/workos-php
that referenced
this pull request
Mar 28, 2025
…ndard attributes (workos#261)
nicknisi
pushed a commit
that referenced
this pull request
Apr 2, 2025
* Improve Webhook and BaseWorkOSResource PHPDoc types * Enhance Webhook class with improved code style and PHPDoc annotations * Add accessToken and refreshToken to AuthenticationResponse class * Update AuthenticationResponse class to include organizationId as nullable, and add accessToken, refreshToken, and impersonator properties * Enhance OrganizationMembership class with additional PHPDoc properties for improved type documentation * Add metadata and external id (#268) And allow to be passed when creating or updating a user or organization. * Add email standard attribute to DirectoryUser and mark deprecated standard attributes (#261) * Add function to get organization by external id (#270) And fix typo in getOrganization docstring * Add support for creating, getting and updating users with external_id property (#267) Co-authored-by: Eric Roberts <ericroberts@gmail.com> * Bump to version 4.22.0. (#269) * Structured responses to webhook events (#265) * Add WebhookResponse class for handling webhook actions and responses * Refactor WebhookResponse create method and improve validation * Resolve linting error --------- Co-authored-by: Braden Keith <bkeith@romegadigital.com> * Update deprecation notices in DirectoryUser class to include version information and improve clarity * Update deprecation notices in Organizations class to include version information and improve formatting * Update doc blocks for deprecation notices * Update tests to expect Role Slug --------- Co-authored-by: Braden Keith <bkeith@romegadigital.com> Co-authored-by: Eric Roberts <ericroberts@gmail.com> Co-authored-by: Matt Dzwonczyk <9063128+mattgd@users.noreply.github.com> Co-authored-by: Pepe <pgarciag93@gmail.com>
bradenkeith
added a commit
to bradenkeith/workos-php
that referenced
this pull request
Apr 3, 2025
* Improve Webhook and BaseWorkOSResource PHPDoc types * Enhance Webhook class with improved code style and PHPDoc annotations * Add accessToken and refreshToken to AuthenticationResponse class * Update AuthenticationResponse class to include organizationId as nullable, and add accessToken, refreshToken, and impersonator properties * Enhance OrganizationMembership class with additional PHPDoc properties for improved type documentation * Add metadata and external id (workos#268) And allow to be passed when creating or updating a user or organization. * Add email standard attribute to DirectoryUser and mark deprecated standard attributes (workos#261) * Add function to get organization by external id (workos#270) And fix typo in getOrganization docstring * Add support for creating, getting and updating users with external_id property (workos#267) Co-authored-by: Eric Roberts <ericroberts@gmail.com> * Bump to version 4.22.0. (workos#269) * Structured responses to webhook events (workos#265) * Add WebhookResponse class for handling webhook actions and responses * Refactor WebhookResponse create method and improve validation * Resolve linting error --------- Co-authored-by: Braden Keith <bkeith@romegadigital.com> * Update deprecation notices in DirectoryUser class to include version information and improve clarity * Update deprecation notices in Organizations class to include version information and improve formatting * Update doc blocks for deprecation notices * Update tests to expect Role Slug --------- Co-authored-by: Braden Keith <bkeith@romegadigital.com> Co-authored-by: Eric Roberts <ericroberts@gmail.com> Co-authored-by: Matt Dzwonczyk <9063128+mattgd@users.noreply.github.com> Co-authored-by: Pepe <pgarciag93@gmail.com>
bradenkeith
pushed a commit
to bradenkeith/workos-php
that referenced
this pull request
Apr 3, 2025
…ndard attributes (workos#261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add email standard attribute to DirectoryUser and mark deprecated standard attributes.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.