feat: add resourceTypeSlug to permissions, environment and organization roles#1502
Merged
feat: add resourceTypeSlug to permissions, environment and organization roles#1502
resourceTypeSlug to permissions, environment and organization roles#1502Conversation
Contributor
Greptile SummaryThis PR adds
The implementation follows existing codebase patterns for optional field serialization and maintains consistency across all entity types. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 5006e80 |
atainter
approved these changes
Feb 26, 2026
Contributor
atainter
left a comment
There was a problem hiding this comment.
Should we give slug the default value of organization? We decided to make it optional at the API level right? Maybe we keep it optional here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resourceTypeSlugto permission, environment role, and organization role response deserializationresourceTypeSlugto permission and environment role creation serializationDocumentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.