Skip to content

Remove dsync.deactivated event #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattgd merged 2 commits into from
Feb 28, 2025
Merged

Remove dsync.deactivated event #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d2f8c
Deprecate dsync deactivated
kendallstrautman Jul 24, 2024
de80495
Delete event entirely
kendallstrautman Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/common/interfaces/event.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,6 @@ export interface DsyncActivatedEventResponse extends EventResponseBase {
data: EventDirectoryResponse;
}

export interface DsyncDeactivatedEvent extends EventBase {
event: 'dsync.deactivated';
data: EventDirectory;
}

export interface DsyncDeactivatedEventResponse extends EventResponseBase {
event: 'dsync.deactivated';
data: EventDirectoryResponse;
}

export interface DsyncDeletedEvent extends EventBase {
event: 'dsync.deleted';
data: Omit<EventDirectory, 'domains' | 'externalKey'>;
Expand Down Expand Up @@ -501,7 +491,6 @@ export type Event =
| ConnectionDeactivatedEvent
| ConnectionDeletedEvent
| DsyncActivatedEvent
| DsyncDeactivatedEvent
| DsyncDeletedEvent
| DsyncGroupCreatedEvent
| DsyncGroupUpdatedEvent
Expand Down Expand Up @@ -543,7 +532,6 @@ export type EventResponse =
| ConnectionDeactivatedEventResponse
| ConnectionDeletedEventResponse
| DsyncActivatedEventResponse
| DsyncDeactivatedEventResponse
| DsyncDeletedEventResponse
| DsyncGroupCreatedEventResponse
| DsyncGroupUpdatedEventResponse
Expand Down
1 change: 0 additions & 1 deletion src/common/serializers/event.serializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export const deserializeEvent = (event: EventResponse): Event => {
data: deserializeConnection(event.data),
};
case 'dsync.activated':
case 'dsync.deactivated':
return {
...eventBase,
event: event.event,
Expand Down