Add audit logs app #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
October 11, 2022 14:26
|
@chaselancaster can we add a readme.md file similar to https://github.com/workos/ruby-example-applications/blob/main/ruby-sso-example/README.md? I believe each example app should have a good one for reference :-) |
sheldonvaughn
suggested changes
Nov 7, 2022
ruby-audit-logs-example/.env.example
Outdated
| @@ -0,0 +1,3 @@ | |||
| WORKOS_API_KEY='sk_test_a2V5XzAxRzVIOTlOMEJXQkczOFlURlhQMFIxV1BHLGhjZlZBaG5PUUVpTWVNQ3FJOEFJSVVHWWM' | |||
There was a problem hiding this comment.
You'll want to drop these credentials before pushing, and also probably cycle your API key as it's going to be in this PR history.
ruby-audit-logs-example/.env.example
Outdated
| @@ -0,0 +1,3 @@ | |||
| WORKOS_API_KEY='sk_test_a2V5XzAxRzVIOTlOMEJXQkczOFlURlhQMFIxV1BHLGhjZlZBaG5PUUVpTWVNQ3FJOEFJSVVHWWM' | |||
| WORKOS_CLIENT_ID='client_01G5H99N125YCD713P4BWMRRQ1' | |||
| WORKOS_CONNECTION_ID='conn_01GB5XBHWTTKNAGNZG9AYWQHM9' | |||
There was a problem hiding this comment.
I don't think you'll need a connectionId for audit logs
ruby-audit-logs-example/Gemfile
Outdated
|
|
||
| gem 'dotenv', '2.7.6' | ||
| gem 'sinatra', '2.2.0' | ||
| gem 'workos', '2.5.0' |
There was a problem hiding this comment.
This needs to be at least version 2.6.0, the module that introduced audit log functions. I would use 2.9.0.
ruby-audit-logs-example/app.rb
Outdated
| WorkOS.key = ENV['WORKOS_API_KEY'] | ||
|
|
||
| # Input your connection ID from your WorkOS dashboard | ||
| CONNECTION_ID = ENV['WORKOS_CONNECTION_ID'] |
There was a problem hiding this comment.
Don't need a connectionId for audit_logs, safe to remove.
sheldonvaughn
approved these changes
Nov 8, 2022
chaselancaster
deleted the
feature/sup-755-ruby-add-example-app-for-audit-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Audit Logs example app to our suite of other Ruby example apps.